Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI check for whitespace (calling the git workflow for it) #16

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add CI check for whitespace (calling the git workflow for it) #16

merged 1 commit into from
Mar 28, 2024

Conversation

jasonleenaylor
Copy link
Contributor

@jasonleenaylor jasonleenaylor commented Mar 26, 2024 •
edited
Loading

This change is Reviewable

@sillsdevgerrit sillsdevgerrit force-pushed the feature/addWhitespaceCheck branch 4 times, most recently from f617e36 to 3d550d3 Compare March 26, 2024 22:55
@jasonleenaylor jasonleenaylor marked this pull request as draft March 26, 2024 23:24
@jasonleenaylor jasonleenaylor force-pushed the feature/addWhitespaceCheck branch 9 times, most recently from fe90192 to dc881f4 Compare March 27, 2024 18:11
@jasonleenaylor
Add CI check for whitespace
cb5ea84 
* Modelled after the git project whitespace checker
* Adds annotations for any whitespace issues discovered

Change-Id: I7cb38bcb9b632ef73b483207f1ecc7619db653b8
@jasonleenaylor jasonleenaylor marked this pull request as ready for review March 27, 2024 18:23
mark-sil
mark-sil approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @jasonleenaylor)

jasonleenaylor
jasonleenaylor commented Mar 28, 2024
View reviewed changes
Copy link
Contributor Author

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jasonleenaylor)

@jasonleenaylor jasonleenaylor merged commit f87174a into release/9.1 Mar 28, 2024
4 checks passed
@jasonleenaylor jasonleenaylor deleted the feature/addWhitespaceCheck branch March 28, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-sil mark-sil mark-sil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonleenaylor @mark-sil